Use the standard nothrow tag instead of our own type#101811
Merged
jkoritzinsky merged 5 commits intodotnet:mainfrom May 2, 2024
Merged
Use the standard nothrow tag instead of our own type#101811jkoritzinsky merged 5 commits intodotnet:mainfrom
jkoritzinsky merged 5 commits intodotnet:mainfrom
Conversation
Contributor
|
Tagging subscribers to this area: @mangod9 |
AaronRobinsonMSFT
approved these changes
May 2, 2024
Member
|
Thanks! By any chance, does it fix #101708? If so, we can try to run the spmi pipeline. |
Member
Author
|
I found it while investigating that. I don't think this PR will fix it, but I have a follow-up after this one that should fix it. |
michaelgsharp
pushed a commit
to michaelgsharp/runtime
that referenced
this pull request
May 9, 2024
Ruihan-Yin
pushed a commit
to Ruihan-Yin/runtime
that referenced
this pull request
May 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This ensures that we actually override the global
operator new(size_t, const std::nothrow_t&)allocator, helping avoid mixed-allocator problems.