8000 Add top-level controls for VMR to enable/disable system lbiraries by omajid · Pull Request #101797 · dotnet/runtime · GitHub
[go: up one dir, main page]
Skip to content

Add top-level controls for VMR to enable/disable system lbiraries #101797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
omajid wants to merge 1 commit into from
Closed

Add top-level controls for VMR to enable/disable system lbiraries #101797

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions eng/DotNetBuild.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,13 @@
<InnerBuildArgs>$(InnerBuildArgs) $(FlagParameterPrefix)verbosity $(LogVerbosity)</InnerBuildArgs>
<InnerBuildArgs>$(InnerBuildArgs) $(FlagParameterPrefix)nodereuse $(ArcadeFalseBoolBuildArg)</InnerBuildArgs>
<InnerBuildArgs>$(InnerBuildArgs) $(FlagParameterPrefix)warnAsError $(ArcadeFalseBoolBuildArg)</InnerBuildArgs>

<InnerBuildArgs Condition="'$(UseSystemBrotli)' != ''">$(InnerBuildArgs) --cmakeargs -DCLR_CMAKE_USE_SYSTEM_BROTLI=$(UseSystemBrotli)</InnerBuildArgs>
Copy link
Member Author
@omajid omajid May 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implemented by:

<InnerBuildArgs Condition="'$(UseSystemLibunwind)' != ''">$(InnerBuildArgs) --cmakeargs -DCLR_CMAKE_USE_SYSTEM_LIBUNWIND=$(UseSystemLibunwind)</InnerBuildArgs>
Copy link
Member Author
@omajid omajid May 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implemented by:

<InnerBuildArgs Condition="'$(UseSystemLlvmLibunwind)' != ''">$(InnerBuildArgs) --cmakeargs -DCLR_CMAKE_USE_SYSTEM_LLVM_LIBUNWIND=$(UseSystemLlvmLibunwind)</InnerBuildArgs>
Copy link
Member Author
@omajid omajid May 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO

<InnerBuildArgs Condition="'$(UseSystemRapidjson)' != ''">$(InnerBuildArgs) --cmakeargs -DCLR_CMAKE_USE_SYSTEM_RAPIDJSON=$(UseSystemRapidjson)</InnerBuildArgs>
Copy link
Member Author
@omajid omajid May 2, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implemented by:

<InnerBuildArgs Condition="'$(UseSystemZlib)' != ''">$(InnerBuildArgs) --cmakeargs -DCLR_CMAKE_USE_SYSTEM_ZLIB=$(UseSystemZlib)</InnerBuildArgs>
Copy link
Member Author
@omajid omajid May 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO


<InnerBuildArgs Condition="'$(SourceBuildUseMonoRuntime)' == 'true'">$(InnerBuildArgs) $(FlagParameterPrefix)usemonoruntime</InnerBuildArgs>
<!-- TODO: This parameter is only available on the Unix script. Intentional? -->
<InnerBuildArgs Condition="'$(OS)' != 'Windows_NT'">$(InnerBuildArgs) --outputrid $(TargetRid)</InnerBuildArgs>
Expand Down
0