update CPS package version #9663
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
drewnoakes
reviewed
May 27, 2025
| <!-- Pin MessagePack to a patched version with security vulnerable fix --> | ||
| <PackageReference Include="MessagePack" /> |
There was a problem hiding this comment.
Can we remove this pin now, if we get a good version via a transitive reference? This was only added to work around such an issue.
There was a problem hiding this comment.
Since MessagePack is bound in devenv.exe.config, it would be better to pin the specific package version so it's not surprisingly updated?
There was a problem hiding this comment.
There are quite a few packages that we depend upon indirectly. We generally only add these pins when we need to (for component governance issues) and try to remove them again once things settle. It reduces the number of package updates we have to manually define in PRs like. Not a big deal though.
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
drewnoakes
approved these changes
May 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update CPS package version to the latest so we can consume
IFileWatcherServicefrom there instead of creating our own file watch server inLaunchSettingsProviderRelated issue: