10000 Update version for 5.0 by ericstj · Pull Request #7311 · dotnet/machinelearning · GitHub
[go: up one dir, main page]
Skip to content

Update version for 5.0 #7311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 18, 2024
Merged

Update version for 5.0 #7311

merged 1 commit into from
Nov 18, 2024

Conversation

ericstj
Copy link
Member
@ericstj ericstj commented Nov 14, 2024

No description provided.

tarekgh
tarekgh reviewed Nov 14, 2024
View reviewed changes
eng/BranchInfo.props
</PropertyGroup>
<PropertyGroup Condition="'$(IsStableProject)' != 'true'">
<MajorVersion>0</MajorVersion>
<MinorVersion>22</MinorVersion>
<MinorVersion>23</MinorVersion>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

23

can this get generated from year number? just thought :-)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, but I could calculate it from the stable product version. That would be more refactoring than I wanted to do.

@codecov Codecov
Copy link
codecov bot commented Nov 14, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.88%. Comparing base (5090327) to head (3b21c68).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #7311   +/-   ##
=======================================
  Coverage   68.87%   68.88%           
=======================================
  Files        1470     1470           
  Lines      274005   274005           
  Branches    28403    28403           
=======================================
+ Hits       188717   188736   +19     
+ Misses      77970    77949   -21     
- Partials     7318     7320    +2
Flag Coverage Δ
Debug 68.88% <ø> (+<0.01%) ⬆️
production 63.29% <ø> (+<0.01%) ⬆️
test 89.40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 7 files with indirect coverage changes

---- 🚨 Try these New Features:

This was referenced Nov 14, 2024
Open
Closed
@tarekgh tarekgh mentioned this pull request Nov 18, 2024
Closed
@ericstj ericstj merged commit d4bc05d into dotnet:main Nov 18, 2024
22 of 25 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tarekgh tarekgh tarekgh approved these changes

@michaelgsharp michaelgsharp Awaiting requested review from michaelgsharp

Assignees

@ericstj ericstj

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ericstj @tarekgh
0