ElementwiseEquals on DateTime column #6831
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #6831 +/- ##
==========================================
+ Coverage 68.99% 69.00% +0.01%
==========
8000
================================
Files 1237 1237
Lines 253558 253563 +5
Branches 26542 26542
==========================================
+ Hits 174944 174979 +35
+ Misses 71663 71634 -29
+ Partials 6951 6950 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
asmirnov82
suggested changes
Sep 19, 2023
| @@ -1884,7 +1884,8 @@ internal PrimitiveDataFrameColumn<bool> ElementwiseEqualsImplementation<U>(Primi | |||
| { | |||
| throw new NotSupportedException(); | |||
| } | |||
| return new BooleanDataFrameColumn(Name, (this as PrimitiveDataFrameColumn<U>)._columnContainer.ElementwiseEquals(column._columnContainer)); | |||
There was a problem hiding this comment.
You shouldn't modify PrimitiveDataFrameColumn.BinaryOperations.cs directly. It's autogenerated from T4 template - PrimitiveDataFrameColumn.BinaryOperations.tt
Could you please modify a template file instead?
I would suggest this change to get required results:
|
git |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Invoking ElementwiseEquals on a PrimitiveDataFrameColumn obtained by accessing DataFrame["ColumnName"] throws NullReferenceException
#6829