-
Notifications
You must be signed in to change notification settings - Fork 857
{{ message }}
Add OpenTelemetrySpeechToTextClient and friends#6845
Merged
stephentoub merged 1 commit intodotnet:mainfrom Sep 30, 2025
Merged
Conversation
This is basically the chat client OpenTelemetry client copy/pasted/tweaked to compile. The otel spec doesn't have anything specific to this modality yet, so this is making best guesses on what things should be and also being minimal in what's tracked.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds OpenTelemetry support for speech-to-text clients by implementing OpenTelemetry telemetry tracking that follows the OpenTelemetry Semantic Conventions for Generative AI systems. The implementation includes comprehensive activity tracing, metrics collection, and sensitive data handling options.
- Adds OpenTelemetrySpeechToTextClient with full telemetry support including activities, metrics, and error tracking
- Provides builder extension methods for easy integration into the speech-to-text client pipeline
- Includes comprehensive test coverage for both streaming and non-streaming scenarios with sensitive data handling
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| OpenTelemetrySpeechToTextClient.cs | Core implementation with activity tracing, metrics collection, and response handling for both streaming and non-streaming operations |
| OpenTelemetrySpeechToTextClientBuilderExtensions.cs | Extension methods to add OpenTelemetry support to the speech-to-text client builder pipeline |
| OpenTelemetrySpeechToTextClientTests.cs | Comprehensive test suite covering streaming/non-streaming scenarios and sensitive data configuration |
| SpeechToTextClientBuilder.cs | Documentation fixes changing "audio transcription" references to "speech-to-text" |
| LoggingSpeechToTextClientBuilderExtensions.cs | Documentation fix changing "audio transcription" to "speech-to-text" |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
src/Libraries/Microsoft.Extensions.AI/SpeechToText/OpenTelemetrySpeechToTextClient.cs
Show resolved
Hide resolved
eiriktsarpalis
approved these changes
Sep 30, 2025
This was referenced Oct 14, 2025
Closed
Merged
This was referenced Oct 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is basically the chat client OpenTelemetry client copy/pasted/tweaked to compile. The otel spec doesn't have anything specific to this modality yet, so this is making best guesses on what things should be and also being minimal in what's tracked, effectively a pure subset of what chat client outputs.
Microsoft Reviewers: Open in CodeFlow