8000 Add netstandard2.0 compatibility to Microsoft.Extensions.Diagnostics.Testing and dependencies by bdovaz · Pull Request #6219 · dotnet/extensions · GitHub
[go: up one dir, main page]
Skip to content

Add netstandard2.0 compatibility to Microsoft.Extensions.Diagnostics.Testing and dependencies #6219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add netstandard2.0 compatibility to Microsoft.Extensions.Diagnostics.Testing and dependencies #6219

wants to merge 1 commit into from

Conversation

bdovaz
Copy link
@bdovaz bdovaz commented Mar 31, 2025 •
edited by dotnet-policy-service bot
Loading

Fixes #5022 (comment)

I have based on the format of this project to change the target frameworks:

extensions/src/Libraries/Microsoft.Extensions.Compliance.Abstractions/Microsoft.Extensions.Compliance.Abstractions.csproj

Line 4 in 56df0c4

<TargetFrameworks>$(NetCoreTargetFrameworks);netstandard2.0;</TargetFrameworks>

Microsoft Reviewers: Open in CodeFlow

@bdovaz bdovaz requested a review from a team as a code owner March 31, 2025 20:32
@RussKie RussKie added the waiting-author-feedback 📭 The author of this issue needs to respond in order for us to continue investigating this issue. label Apr 7, 2025
@bdovaz
Copy link
Author
bdovaz commented Apr 21, 2025

What feedback?

@dotnet-policy-service dotnet-policy-service bot removed waiting-author-feedback 📭 The author of this issue needs to respond in order for us to continue investigating this issue. no-recent-activity 💤 labels Apr 21, 2025
@RussKie
Copy link
Contributor
RussKie commented Apr 21, 2025

The build is failing

@RussKie RussKie added the waiting-author-feedback 📭 The author of this issue needs to respond in order for us to continue investigating this issue. label Apr 21, 2025
@bdovaz
Copy link
Author
bdovaz commented Apr 22, 2025 •
edited
Loading

@RussKie I don't understand the error if the only thing I have changed is the target frameworks. The errors are very similar to each other:

.dotnet\sdk\9.0.104\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.ApiCompat.ValidatePackage.targets(39,5): error : (NETCORE_ENGINEERING_TELEMETRY=Build) API compatibility errors between 'lib/net462/Microsoft.Extensions.Telemetry.Abstractions.dll' (D:\a_work\1\s.packages\microsoft.extensions.telemetry.abstractions\9.3.0\microsoft.extensions.telemetry.abstractions.9.3.0.nupkg) and 'lib/netstandard2.0/Microsoft.Extensions.Telemetry.Abstractions.dll' (D:\a_work\1\s\artifacts\packages\Release\Shipping\Microsoft.Extensions.Telemetry.Abstractions.9.4.0-ci.nupkg):

@dotnet-policy-service dotnet-policy-service bot removed the waiting-author-feedback 📭 The author of this issue needs to respond in order for us to continue investigating this issue. label Apr 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

53AD @bdovaz bdovaz

Labels
area-telemetry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Microsoft.Extensions.Http.Resilience .NET Standard compatible
2 participants
@bdovaz @RussKie
0