10000 Tweak MetaData Report format for better readability by IbrahimMNada · Pull Request #5929 · dotnet/extensions · GitHub
[go: up one dir, main page]

Skip to content

Tweak MetaData Report format for better readability #5929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 84 commits into from
Closed
Changes from 1 commit
Commits
Show all changes
84 commits
Select commit Hold shift + click to select a range
1c62ee0
fix report format
IbrahimMNada Feb 18, 2025
0d87e45
Merge branch 'dotnet:main' into audit-report-format
IbrahimMNada Feb 19, 2025
e4ccb48
adding normalize escapes in order to handle differences between windo…
IbrahimMNada Feb 19, 2025
b54420a
Merge branch 'audit-report-format' of https://github.com/IbrahimMNada…
IbrahimMNada Feb 19, 2025
16be34f
remove unneeded Encoding.UTF8
IbrahimMNada Feb 19, 2025
caf5068
adding comment to make azure piplines happy
IbrahimMNada Feb 19, 2025
496f9f1
use temp file isnted of static ReportFileName for metadata
IbrahimMNada Feb 19, 2025
d9049fc
use temp file isnted of static ReportFileName for metrics report
IbrahimMNada Feb 19, 2025
e9f2cdd
remove white space
IbrahimMNada Feb 19, 2025
82edd87
add space
IbrahimMNada Feb 19, 2025
32bdb46
remove multiple blanks
IbrahimMNada Feb 19, 2025
a6a520c
fix checks
IbrahimMNada Feb 19, 2025
1374258
Merge branch 'main' into audit-report-format
IbrahimMNada Feb 20, 2025
edfec34
-adding parameter needs to parameterless constructors
IbrahimMNada Feb 20, 2025
9825774
Merge branch 'audit-report-format' of https://github.com/IbrahimMNada…
IbrahimMNada Feb 20, 2025
6d136e4
rename temp to temporaryReportFile & change var to actual type
IbrahimMNada Feb 20, 2025
b3d9357
remove unneeded check
IbrahimMNada Feb 20, 2025
48d0b6f
adding comment
IbrahimMNada Feb 20, 2025
ddb58f4
Merge branch 'main' into audit-report-format
IbrahimMNada Feb 20, 2025
dfb4e14
Merge branch 'main' into audit-report-format
IbrahimMNada Feb 21, 2025
ab59a4a
introduce MetadataEmitter
IbrahimMNada Feb 24, 2025
b49fc54
a
IbrahimMNada Feb 24, 2025
fb1118f
Merge branch 'audit-report-format' of https://github.com/IbrahimMNada…
IbrahimMNada Feb 24, 2025
76c4007
Adding Indentation for complince
IbrahimMNada Feb 24, 2025
98fceae
fix indentation on metrics
IbrahimMNada Feb 24, 2025
ed829de
fix form,at
IbrahimMNada Feb 24, 2025
04e0c10
Fix format for unit testing
IbrahimMNada Feb 24, 2025
4e0962a
fixing metrics formats
IbrahimMNada Feb 24, 2025
2da5f0a
fix checker
IbrahimMNada Feb 24, 2025
f095df6
Merge branch 'main' into audit-report-format
IbrahimMNada Feb 24, 2025
b8d598c
fix checks
IbrahimMNada Feb 24, 2025
0bb634a
Merge branch 'audit-report-format' of https://github.com/IbrahimMNada…
IbrahimMNada Feb 24, 2025
705e34a
Merge branch 'main' into audit-report-format
IbrahimMNada Feb 24, 2025
44b512f
adding overloads for indent
IbrahimMNada Feb 25, 2025
1df3627
enhance indentation
IbrahimMNada Feb 25, 2025
9bf78fc
Merge branch 'main' into audit-report-format
IbrahimMNada Feb 26, 2025
a454fed
fix namings
IbrahimMNada Feb 26, 2025
6edc0e3
remove white space before comma"ComplianceReport": {},
IbrahimMNada Feb 26, 2025
9d41481
rename const
IbrahimMNada Feb 26, 2025
b893bdc
fix namings
IbrahimMNada Feb 27, 2025
89c99dc
fix comma on new line
IbrahimMNada Feb 27, 2025
821513b
Merge branch 'main' into audit-report-format
IbrahimMNada Feb 27, 2025
5458782
fix idnentation
IbrahimMNada Mar 1, 2025
cc4c394
introduce JsonEmitterBase
IbrahimMNada Mar 2, 2025
bf7af23
remove blanks
IbrahimMNada Mar 2, 2025
0d4c102
overload OutNameValue
IbrahimMNada Mar 2, 2025
83b22d8
Merge branch 'main' into audit-report-format
IbrahimMNada Mar 2, 2025
53eff19
rerun
IbrahimMNada Mar 2, 2025
ac2996d
made metadata consume OutObject
IbrahimMNada Mar 2, 2025
befb637
rerun
IbrahimMNada Mar 2, 2025
7317e69
1
IbrahimMNada Mar 2, 2025
5eb1f9b
metric reports
IbrahimMNada Mar 3, 2025
48a0647
metrics
IbrahimMNada Mar 3, 2025
bb917df
apply json emitter
IbrahimMNada Mar 3, 2025
c8eb0df
fixing spaces
IbrahimMNada Mar 3, 2025
517a89b
Merge branch 'main' into audit-report-format
IbrahimMNada Mar 3, 2025
e06ff73
Merge branch 'main' into audit-report-format
IbrahimMNada Mar 4, 2025
5ea0202
Merge branch 'main' into audit-report-format
IbrahimMNada Mar 6, 2025
a893d16
Merge branch 'main' into audit-report-format
IbrahimMNada Mar 7, 2025
b6ae7c0
Merge branch 'main' into audit-report-format
IbrahimMNada Mar 8, 2025
ba7995f
Merge branch 'main' into audit-report-format
IbrahimMNada Mar 12, 2025
8c3fe50
remove JsonEmitterBase Compile ref when unneeded
IbrahimMNada Mar 12, 2025
0a955b6
Unindent
IbrahimMNada Mar 12, 2025
ddfa3bb
adding is root to neglect any extra indentation before the brace
IbrahimMNada Mar 12, 2025
ddaecc3
Trigger pipelines
IbrahimMNada Mar 12, 2025
53fb4ce
remove indentation from Dimensions
IbrahimMNada Mar 12, 2025
45fa002
Merge branch 'main' into audit-report-format
IbrahimMNada Mar 14, 2025
b8b4d25
Merge branch 'main' into audit-report-format
IbrahimMNada Mar 14, 2025
9702ba0
Merge branch 'main' into audit-report-format
IbrahimMNada Mar 15, 2025
750dce0
Merge branch 'main' into audit-report-format
IbrahimMNada Mar 17, 2025
b0bef0f
Merge branch 'main' into audit-report-format
IbrahimMNada Mar 19, 2025
c4ed8a1
Merge branch 'main' into audit-report-format
IbrahimMNada Mar 20, 2025
7ca665d
Merge branch 'main' into audit-report-format
IbrahimMNada Mar 21, 2025
1679ccf
Merge branch 'main' into audit-report-format
IbrahimMNada Mar 25, 2025
bad5927
Merge branch 'main' into audit-report-format
IbrahimMNada Mar 27, 2025
e402cad
Merge branch 'main' into audit-report-format
IbrahimMNada Apr 9, 2025
cbb1303
Merge branch 'main' into audit-report-format
IbrahimMNada May 5, 2025
acdd785
Merge branch 'main' into audit-report-format
IbrahimMNada May 14, 2025
2d31861
Merge branch 'main' into audit-report-format
IbrahimMNada May 24, 2025
1aad0fc
Merge branch 'main' of https://github.com/IbrahimMNada/extensions
IbrahimMNada Jun 2, 2025
4f0560f
Merge branch 'main' into audit-report-format
IbrahimMNada Jun 2, 2025
dde2803
Merge branch 'audit-report-format' of https://github.com/IbrahimMNada…
IbrahimMNada Jun 2, 2025
b379796
generated snapshots for tests
IbrahimMNada Jun 2, 2025
c8532b5
Merge branch 'main' into audit-report-format
IbrahimMNada Jun 12, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
10774
Diff view
Diff view
Prev Previous commit
Next Next commit
adding is root to neglect any extra indentation before the brace
  • Loading branch information
IbrahimMNada committed Mar 12, 2025
commit ddfa3bb2ef2a8bc18c919172d5565b5b3e26e8dc
3 changes: 2 additions & 1 deletion src/Generators/Shared/EmitterBase.cs
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,8 @@ public EmitterBase(bool emitPreamble = true)

protected void OutCloseBrace(bool isRoot = false)// isRoot is used to neglect any extra indentation before the brace, root has no indentation, defaulted to false for backward compatibility.
{
Unindent();

if (isRoot)
{
Out("}");
Expand All @@ -62,7 +64,6 @@ public EmitterBase(bool emitPreamble = true)
OutLn("}");
}

Unindent();
}

protected void OutCloseBraceWithExtra(string extra)
Expand Down
Loading
0