8000 Named query filters by bittola · Pull Request #36028 · dotnet/efcore · GitHub
[go: up one dir, main page]
Skip to content

Named query filters #36028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
Jun 9, 2025
Merged

Named query filters #36028

merged 18 commits into from
Jun 9, 2025
+1,096 −103

Conversation

bittola
Copy link
Contributor
@bittola bittola commented May 2, 2025 •
edited by cincuranet
Loading
  • I've read the guidelines for contributing and seen the walkthrough
  • I've posted a comment on an issue with a detailed description of how I am planning to contribute and got approval from a member of the team
  • The code builds and tests pass locally (also verified by our automated build checks)
  • Tests for the changes have been added (for bug fixes / features)
  • Code follows the same patterns and style as existing code in this repo

Closes: #8576
Closes: #10275

@bittola bittola requested a review from a team as a code owner May 2, 2025 02:58
@bittola bittola marked this pull request as draft May 2, 2025 04:47
@bittola bittola marked this pull request as ready for review May 2, 2025 06:10
@bittola bittola changed the title Bittola/named query filters Named query filters May 2, 2025
AndriySvyryd
AndriySvyryd reviewed May 2, 2025
View reviewed changes
AndriySvyryd
AndriySvyryd reviewed May 2, 2025
View reviewed changes
AndriySvyryd
AndriySvyryd reviewed May 2, 2025
View reviewed changes
AndriySvyryd
AndriySvyryd reviewed May 2, 2025
View reviewed changes
@AndriySvyryd
Copy link
Member

Also add tests in InternalEntityTypeBuilderTest to verify that named filters set using ConfigurationSource.Convention can be removed or overridden by ConfigurationSource.Explicit or ConfigurationSource.DataAnnotation, but not the other way around.

maumar
maumar reviewed May 12, 2025
View reviewed changes
maumar
maumar reviewed May 15, 2025
View reviewed changes
AndriySvyryd
AndriySvyryd reviewed May 15, 2025
View reviewed changes
AndriySvyryd
AndriySvyryd reviewed May 15, 2025
View reviewed changes
AndriySvyryd
AndriySvyryd reviewed May 15, 2025
View reviewed changes
AndriySvyryd
AndriySvyryd reviewed May 15, 2025
View reviewed changes
AndriySvyryd
AndriySvyryd reviewed May 15, 2025
View reviewed changes
AndriySvyryd
AndriySvyryd reviewed May 15, 2025
View reviewed changes
AndriySvyryd
AndriySvyryd reviewed May 15, 2025
View reviewed changes
AndriySvyryd
AndriySvyryd reviewed May 15, 2025
View reviewed changes
@AndriySvyryd AndriySvyryd assigned AndriySvyryd and unassigned maumar May 19, 2025
AndriySvyryd
AndriySvyryd reviewed May 19, 2025
View reviewed changes
AndriySvyryd
AndriySvyryd reviewed May 19, 2025
View reviewed changes
AndriySvyryd
AndriySvyryd reviewed May 19, 2025
View reviewed changes
AndriySvyryd
AndriySvyryd reviewed May 20, 2025
View reviewed changes
@AndriySvyryd AndriySvyryd requested a review from cincuranet May 21, 2025 00:22
cincuranet
cincuranet requested changes Jun 4, 2025
View reviewed changes
@cincuranet cincuranet self-assigned this Jun 4, 2025
@cincuranet cincuranet merged commit ab1b36e into dotnet:main Jun 9, 2025
7 checks passed
@cincuranet
Copy link
Contributor

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maumar maumar maumar left review comments

@cincuranet cincuranet cincuranet approved these changes

@AndriySvyryd AndriySvyryd AndriySvyryd approved these changes

Assignees

@cincuranet cincuranet

@AndriySvyryd AndriySvyryd

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support multiple HasQueryFilter calls on same entity type Named query filters
4 participants
@bittola @AndriySvyryd @cincuranet @maumar
0