Fix some threading docs #4961
Fix some threading docs #4961
Conversation
|
Docs Build status updates of commit 03461d5:
|
|
Made a couple of fixes to note some subtle differences |
…isting may return false for invalid names in some cases
|
Docs Build status updates of commit 440b9d2: ❌ Validation status: errorsPlease follow instructions here which may help to resolve issue.
For more details, please refer to the build report. If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them. For any questions, please:
|
|
Rebased to fix conflicts. The last two commits are new. |
|
Docs Build status updates of commit dade40b:
|
|
Docs Build status updates of commit dade40b:
|
|
Not sure what the validation warning is referring to, I don't see any non-unique constructor signatures |
|
I think this is ready to merge. It looks like the approval has disappeared, maybe after I closed/reopened the issue to work around a CI validation issue above. @mangod9 could you please approve again? |
|
Approved again, but perhaps it requires approval from the docs team. |
|
Thanks! @gewarren could you please also take a quick look? |
| @@ -53,20 +53,29 @@ | |||
| <format type="text/markdown"><. |
There was a problem hiding this comment.
It looks like "Unixes" is the common plural form and can also be used to refer to Unix-like systems. I think your suggestion is more clear, changed to "On Unix-like operating systems...".
| <exception cref="T:System.Threading.WaitHandleCannotBeOpenedException">A system-wide synchronization event with the provided <paramref name="name" /> was not found. | ||
| -or- An <see cref="T:System.Threading.EventWaitHandle" /> with system-wide name <paramref name="name" /> cannot be created. An <see cref="T:System.Threading.EventWaitHandle" /> of a different type might have the same name.</exception> | ||
| .NET Framework only: <paramref name="name" /> is longer than MAX_PATH (260 characters).</exception> | ||
| <exception cref="T:System.ArgumentOutOfRangeException">The <paramref name="mode" /> enum value was out of legal range. In some cases <see cref="T:System.ArgumentException"/> is thrown, so use that instead.</exception> |
There was a problem hiding this comment.
What does "use that instead" mean? Do you mean "catch that instead"?
There was a problem hiding this comment.
I didn't want to suggest catching this exception, I just removed that part and just noted the different exception that may be thrown. Also removed another similar usage for DirectoryNotFoundException.
|
Docs Build status updates of commit 9d8d720:
|
|
@gewarren could you please take a look at the changes above? |
ExecutionContext.RestoreExecutionContextdocs for .NET CoreFixes dotnet/runtime#35519
Fixes dotnet/runtime#35518
Fixes #4585
Fixes #4448