-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Add ssl API added between preview 7 and 8 #4860
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -40,7 +40,7 @@ | |
<ReturnType>System.String</ReturnType> | ||
</ReturnValue> | ||
<Docs> | ||
<summary>To be added.</summary> | ||
<summary>The host server specif 10000 ied by the client.</summary> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I would change that to "The host server specified by the client in Server Name extension (SNI). If the extension is not present this returns empty string. |
||
<value>To be added.</value> | ||
<remarks>To be added.</remarks> | ||
</Docs> | ||
|
@@ -61,8 +61,8 @@ | |
<ReturnType>System.Security.Authentication.SslProtocols</ReturnType> | ||
</ReturnValue> | ||
<Docs> | ||
<summary>To be added.</summary> | ||
<value>To be added.</value> | ||
<summary>Gets or sets the TLS/SSL protocols offered by client.</summary> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There really should not be setter. Both properties are |
||
<value>A bitwise combination of the enumeration values that specify the TLS or SSL protocols.</value> | ||
<remarks>To be added.</remarks> | ||
</Docs> | ||
</Member> | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -14,7 +14,7 @@ | |
</Base> | ||
<Interfaces /> | ||
<Docs> | ||
<summary>To be added.</summary> | ||
<summary>Represents a set of certificates used for building a certificate chain.</summary> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I would add note that the certificates are normalized and if something is missing in constructed X509Chain, SslStream will try to resolve them - either by searching certificates stores or by fetching them via network if allowed. |
||
<remarks>To be added.</remarks> | ||
</Docs> | ||
<Members> | ||
|
@@ -38,12 +38,15 @@ | |
<Parameter Name="offline" Type="System.Boolean" /> | ||
</Parameters> | ||
<Docs> | ||
<param name="target">To be added.</param> | ||
<param name="additionalCertificates">To be added.</param> | ||
<param name="offline">To be added.</param> | ||
<summary>To be added.</summary> | ||
<returns>To be added.</returns> | ||
<param name="target">The server certificate.</param> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I would add bold comment that the certificate must include private key. |
||
<param name="additionalCertificates">The certificates to chain.</param> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I would change this to something like "Supplemental certificates to build the certificate chain." |
||
<param name="offline"> | ||
<see langword="true" /> to indicate that the missing certificates can be downloaded; otherwise, <see langword="false" />.</param> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. otherwise only available X509Certificate stores will be searched for missing certificates. |
||
<summary>Attempts to build the certificate chain from the provided certificates.</summary> | ||
<returns>The certificate context with the newly created certificate chain.</returns> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I would add note that it can be used across many streams to save chain construction and improve performance. |
||
<remarks>To be added.</remarks> | ||
<exception cref="T:System.NotSupportedException"> | ||
<paramref name="target" /> doesn't have an associated private key.</exception> | ||
</Docs> | ||
</Member> | ||
</Members> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.