8000 NET Interactive: Enable_try_dotnet_to_batch_12d by v-mepa · Pull Request #4425 · dotnet/dotnet-api-docs · GitHub
[go: up one dir, main page]
Skip to content

NET Interactive: Enable_try_dotnet_to_batch_12d #4425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 1, 2020
Merged

NET Interactive: Enable_try_dotnet_to_batch_12d #4425

merged 2 commits into from
Jul 1, 2020

Conversation

v-mepa
Copy link
Contributor
@v-mepa v-mepa commented Jun 22, 2020

@dotnet-bot dotnet-bot added this to the June 2020 milestone Jun 22, 2020
@v-mepa
Copy link
Contributor Author
v-mepa commented Jun 22, 2020

fyi @mairaw

@mairaw mairaw self-requested a review June 25, 2020 00:04
@mairaw mairaw added the 👩‍💻 .NET Interactive These issues relate to using .NET Interactive in docs label Jun 25, 2020
@mairaw mairaw closed this Jun 29, 2020
@mairaw mairaw reopened this Jun 29, 2020
mairaw
mairaw requested changes Jun 30, 2020
View reviewed changes
Copy link
Contributor
@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just one small suggestion to be applied.

@v-mepa @mairaw
Update xml/System/Exception.xml
5dec6cf 
Removing interactive

Co-authored-by: Maira Wenzel <mairaw@microsoft.com>
mairaw
mairaw approved these changes Jul 1, 2020
View reviewed changes
Copy link
Contributor
@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks!

@mairaw mairaw merged commit 24edf30 into dotnet:master Jul 1, 2020
@v-mepa v-mepa deleted the add_try_dotnet_to_batch_12d branch July 1, 2020 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mairaw mairaw mairaw approved these changes

Assignees
No one assigned
Labels
👩‍💻 .NET Interactive These issues relate to using .NET Interactive in docs
Projects
None yet
Milestone
June 2020
Development

Successfully merging this pull request may close these issues.
3 participants
@v-mepa @mairaw @dotnet-bot
0