8000 replace rijndael etc by tdykstra · Pull Request #4415 · dotnet/dotnet-api-docs · GitHub
[go: up one dir, main page]
Skip to content

replace rijndael etc #4415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 30, 2020
Merged

replace rijndael etc #4415

merged 4 commits into from
Jun 30, 2020

Conversation

tdykstra
Copy link
Contributor
@tdykstra tdykstra commented Jun 19, 2020 •
edited
Loading

Contributes to dotnet/docs#10199

From the issue:

Samples should not use any of the following cryptography types:

As an alternative, they should reference Aes.

Notes:

  • Samples for symmetricalgorithm.create and cryptography.keysizes create the default symmetric algorithm which is said to be Rijndael, but these don't even run -- they raise an exception saying the platform doesn't allow creation of default algorithm. So I didn't change these.
  • The sample for symmetricalgorithm.legalkeysizes displays key sizes for the four deprecated symmetric algorithms as well as AES. I left it unchanged.
  • The sample for passwordderivebytes uses TripleDes but when I try switching it to AES it fails with the error message "Object identifier (OID) is unknown". I left it unchanged.

@tdykstra tdykstra requested a review from bartonjs June 19, 2020 17:17
@dotnet-bot dotnet-bot added this to the June 2020 milestone Jun 19, 2020
@tdykstra
Copy link
Contributor Author

This is ready for review. I'll make a separate PR for instances of Rijndael in XML encryption samples.

@tdykstra tdykstra merged commit 75eb938 into dotnet:master Jun 30, 2020
@tdykstra tdykstra deleted the cryptotypes branch June 30, 2020 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartonjs bartonjs bartonjs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
June 2020
Development

Successfully merging this pull request may close these issues.
3 participants
@tdykstra @bartonjs @dotnet-bot
0