SslProtocols update #4410
Merged
SslProtocols update #4410
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes dotnet/docs#10201
Per the issue:
SslProtocols.Default should not be used; it should be replaced with SslProtocols.None.
No instances using SslProtocols.Default were found.
The documentation for Tls should be added to note that it's provided for backward compatibility only.
Added note to SslProtocols.Tls.
SslProtocols.Ssl2, SslProtocols.Ssl3, and SslProtocols.Tls are all obsolete. Use the OS default (None).
Found instances of SslProtocols.Ssl3 and SslProtocols.Tls in snippet files, changed them to SslProtocols.None -- but the Snippet7 that they occur in isn't actually used anywhere.