SocketsHttpHandler - update documentation #4290
Conversation
Co-authored-by: Maira Wenzel <mairaw@microsoft.com>
…otnet-api-docs into jajahoda/SocketsHttpHandler
Co-authored-by: Karel Zikmund <karelz@microsoft.com> Co-authored-by: Maira Wenzel <mairaw@microsoft.com>
…otnet-api-docs into jajahoda/SocketsHttpHandler
| ## Remarks | ||
| This property define maximal connection lifetime in the pool regardles the connection is idle or active. The connection should be reestablished periodically to reflect the DNS TTL. There is no link between actuall DNS TTL and this property and the property shoul be set manually. | ||
|
|
||
| If the connection endpoint is not the Doamin name but the IP address, the value can be <xref:System.Threading.Timeout.InfiniteTimeSpan>. |
There was a problem hiding this comment.
Is this based on the code? Or is this just hint? The DNS refresh matters only if server is on dynamic IP IMHO.
There was a problem hiding this comment.
It is just a hint. Please correct me there.
I was about more static setup where the server can change its IP because infra changes and DNS reflect this change after TTL.
Any suggestion (change/ truncate the sentence) is appreciate.
There was a problem hiding this comment.
Maybe just say something like
This property defines maximal connection lifetime in the connectioon pool regardles the connection is idle or active. The connection will be reestablished periodically to reflect the DNS or other network changes.
and I would probably remove the part about IP address. I think it is up to the caller to decide if refresh make sense for them or not.
Co-authored-by: Maira Wenzel <mairaw@microsoft.com>
Summary
Collect all changes from #3916 related to ReadOnlyMemoryContent