8000 Document System.Buffers.*SpanAction delegates by carlossanlop · Pull Request #3621 · dotnet/dotnet-api-docs · GitHub
[go: up one dir, main page]
Skip to content

Document System.Buffers.*SpanAction delegates #3621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 4, 2019
Merged

Document System.Buffers.*SpanAction delegates #3621

merged 2 commits into from
Dec 4, 2019

Conversation

carlossanlop
Copy link
Contributor

@carlossanlop carlossanlop added new-content Indicates PRs that contain new articles waiting-on-reviews Indicates PRs that cannot be merged because of the lack of reviews 🏁 Release: .NET Core 2.x Identifies work items for the .NET Core 2.x releases labels Dec 3, 2019
@carlossanlop carlossanlop added this to the December 2019 milestone Dec 3, 2019
@carlossanlop carlossanlop self-assigned this Dec 3, 2019
bartonjs
bartonjs reviewed Dec 3, 2019
View reviewed changes
@carlossanlop @bartonjs
suggestion by bartonjs
239db20 
Co-Authored-By: Jeremy Barton <jbarton@microsoft.com>
@carlossanlop carlossanlop added changes-addressed Indicates PRs that had all comments addressed and are awaiting for new review and removed waiting-on-reviews Indicates PRs that cannot be merged because of the lack of reviews labels Dec 3, 2019
jozkee
jozkee approved these changes Dec 4, 2019
View reviewed changes
Copy link
Member
@jozkee jozkee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@carlossanlop carlossanlop merged commit 32b14c3 into dotnet:master Dec 4, 2019
@carlossanlop carlossanlop deleted the SpanActionDelegates branch December 4, 2019 09:01
stephentoub
stephentoub reviewed Dec 6, 2019
View reviewed changes
Copy link
Member
@stephentoub stephentoub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephentoub stephentoub stephentoub left review comments

@bartonjs bartonjs bartonjs approved these changes

@jozkee jozkee jozkee approved these changes

@JeremyKuhne JeremyKuhne Awaiting requested review from JeremyKuhne

@layomia layomia Awaiting requested review from layomia

Assignees

@carlossanlop carlossanlop

Labels
changes-addressed Indicates PRs that had all comments addressed and are awaiting for new review 🏁 Release: .NET Core 2.x Identifies work items for the .NET Core 2.x releases new-content Indicates PRs that contain new articles
Projects
None yet
Milestone
December 2019
Development

Successfully merging this pull request may close these issues.
4 participants
@carlossanlop @stephentoub @bartonjs @jozkee
0