Add missing documentation for DSA types #3498
Conversation
|
cc: @carlossanlop |
There was a problem hiding this comment.
Thanks for making the change, @bartonjs. I left a couple of questions and a couple of nit suggestions for you to consider.
Co-Authored-By: Maira Wenzel <mairaw@microsoft.com> Co-Authored-By: Carlos Sanchez Lopez <1175054+carlossanlop@users.noreply.github.com>
There was a problem hiding this comment.
Looks good, no build warnings. Pending to answer the seealso vs altmember question, but I think it looks good to merge.
|
@mairaw I'll merge. If we have to change the |
|
There are some warnings here. Please don't merge yet. |
|
I'll take a look at them soon, @mairaw |
| <paramref name="handle" /> is <see cref="F:System.IntPtr.Zero"/>.</exception> | ||
| <exception cref="T:System.Security.Cryptography.CryptographicException"> | ||
| <paramref name="handle"/> is not a valid <c>DSA*</c>.</exception> | ||
| <altmember cref="P:System.Security.Cryptography.SafeEvpPKeyValue.OpenSslVersion" /> |
There was a problem hiding this comment.
build warning due to malformed DocId.
The SafeEvpPKeyValue class should've been SafeEvpPKeyHandle:
| <altmember cref="P:System.Security.Cryptography.SafeEvpPKeyValue.OpenSslVersion" /> | |
| <altmember cref="P:System.Security.Cryptography.SafeEvpPKeyHandle.OpenSslVersion" /> |
| </exception> | ||
| <exception cref="T:System.Security.Cryptography.CryptographicException"> | ||
| <paramref name="parameters"/> does not represent a valid DSA key parameter set.</exception> | ||
| <altmember cref="M:System.Security.Cryptography.DSA.Create(System.Security.Cryptography.DSA.Create(System.Security.Cryptography.DSAParameters)" /> |
There was a problem hiding this comment.
Malformed DocId. There's a Create call inside the Create call. I removed all the similar instances in this file.
No description provided.