Add .NET Framework 4.7.2 APIs #10
Conversation
| @@ -1493,7 +1493,7 @@ | |||
| <Parameter Name="supports" Type="System.CodeDom.Compiler.GeneratorSupport" Index="0" FrameworkAlternate="xamarinmac-3.0" /> | |||
| </Parameters> | |||
| <Docs> | |||
| <param name="supports">To be added.</param> | |||
| <param name="generatorSupport">To be added.</param> | |||
There was a problem hiding this comment.
@joelmartinez @dend I'm a bit confused on what's going on here. Why is the parameter name changing here (and on several other files on this PR) and shouldn't .net-framework-4.7.2 also be on the FrameworkAlternate list on line 1492?
There was a problem hiding this comment.
Hmm ... yeah this is indeed strange. It shouldn't be removing the supports parameter, it should only be adding generatorSupport. I've created a new GH issue, and will work to resolve:
mono/api-doc-tools#222
| <MemberSignature Language="VB.NET" Value="Protected Friend Overrides Sub Unmerge (sourceElement As ConfigurationElement, parentElement As ConfigurationElement, saveMode As ConfigurationSaveMode)" FrameworkAlternate="netcore-2.0;netframework-4.5;netframework-4.5.1;netframework-4.5.2;netframework-4.6;netframework-4.6.1;netframework-4.6.2;netframework-4.7;netframework-4.7.1" /> | ||
| <MemberSignature Language="C++ CLI" Value="protected public:
 override void Unmerge(System::Configuration::ConfigurationElement ^ sourceElement, System::Configuration::ConfigurationElement ^ parentElement, System::Configuration::ConfigurationSaveMode saveMode);" FrameworkAlternate="netcore-2.0;netframework-4.5;netframework-4.5.1;netframework-4.5.2;netframework-4.6;netframework-4.6.1;netframework-4.6.2;netframework-4.7;netframework-4.7.1" /> | ||
| <MemberSignature Language="C#" Value="protected internal override void Unmerge (System.Configuration.ConfigurationElement sourceElement, System.Configuration.ConfigurationElement parentElement, System.Configuration.ConfigurationSaveMode updateMode);" FrameworkAlternate="xamarinmac-3.0" /> | ||
| <MemberSignature Language="ILAsm" Value=".method familyorassemblyhidebysig virtual instance void Unmerge(class System.Configuration.ConfigurationElement sourceElement, class System.Configuration.ConfigurationElement parentElement, valuetype System.Configuration.ConfigurationSaveMode updateMode) cil managed" FrameworkAlternate="xamarinmac-3.0" /> | ||
| <MemberSignature Language="DocId" Value="M:System.Configuration.ConfigurationElementCollection.Unmerge(System.Configuration.ConfigurationElement,System.Configuration.ConfigurationElement,System.Configuration.ConfigurationSaveMode)" FrameworkAlternate="xamarinmac-3.0" /> | ||
| <MemberSignature Language="DocId" Value="M:System.Configuration.ConfigurationElementCollection.Unmerge(System.Configuration.ConfigurationElement,System.Configuration.ConfigurationElement,System.Configuration.ConfigurationSaveMode)" FrameworkAlternate="xamarinmac-3.0;netcore-2.0" /> |
There was a problem hiding this comment.
@joelmartinez @dend another odd one. aren't 1555 and 1560 the same? So why the framework value is jumping lines? shouldn't DocID be the same for all platforms?
There was a problem hiding this comment.
Hmm, this is a little strange yes. Probably an artifact of the fact that the parameter names are different, but the docid is the same as you point out. The value does == ... so strictly speaking, any code that reads these signatures and filters out by FrameworkAlternate will show the correct value.
I will fix this in the future (made a gh issue here, but this in particular shouldn't be a blocking issue since the end result is still correct.
There was a problem hiding this comment.
Sounds good. I agree with you this one is not blocking. I can't open this issue though.
|
I reviewed as Ron did, and this also LGTM. |
Related to dotnet/docs#4876