Consolidate Unix source-only and non-source-only entrypoints #798
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes source-build less special by using the same eng/common/tools.sh MSBuild helper function. This also makes source-build specify the "/m" flag now automatically which wasn't set. That should improve parallel build performance. ... also bring missing flags from eng/common/build.sh in
akoeplinger
approved these changes
May 27, 2025
…t/dotnet into ConsolidateUnixEntryPoints
mthalman
approved these changes
May 27, 2025
This was referenced May 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSBuildhelper function./morwarnaserror. Due to the "/m" flag now getting passed in, the build should be faster by using nodes in parallel.eng/tools/tasks/Microsoft.DotNet.UnifiedBuild.Tasks/CreateSdkSymbolsLayout.cswhich was now failing with/warnaserror.test/Microsoft.DotNet.SourceBuild.Tests/DotNetHelper.csnullability error.