Fix malformed NuGet.config file #550
Conversation
Please loop in the appropriate msbuild folks to review. |
|
PR checks are hitting known NuGet Audit errors - will likely need to wait until #546 is merged before rerunning checks. |
|
@rainersigwald @baronfel it would be great to have a review from someone on the |
|
Logged a bug on the NuGet side asking for some more validation in NuGet.config to prevent these kinds of errors. |
|
Does the dotnet/dotnet -> dotnet/msbuild flow work already? or should I copy the commit to MSBuild manually? |
|
Already works. Should come in tomorrow morning with the backflow subscription: dotnet -> msbuild (main) |
|
It looks like this is breaking our official build on toolset restore; am I correct that @NikolaMilosavljevic's #554 would let us revert this change (and then fix forward shortly)? |
|
Yes, I believe so. |
|
@NikolaMilosavljevic is out this week, btw |
Confirming @mthalman's response of Yes, I believe so, |
Fixes: dotnet/source-build#5122
NuGet.configfile inmsbuildrepo is malformed.packageSourceMappingelement is incorrectly placed underpackageSourceselement. Package source mappings in this, and the file modified by our tasks, are never used by Nuget, causing intermittent failures withNETStandard.Librarybeing picked up frompreviously-source-builtsource, instead ofreferencesource.packageSourceMappingsection was originally added with dotnet/msbuild#11255Fixing in VMR instead of
msbuildrepo, to get this fixed asap.