Reintroduce support for building VMR from repo PR/CI #548
Conversation
eng/common/darc-init.sh
Outdated
| @@ -68,7 +68,7 @@ function InstallDarcCli { | |||
| fi | |||
| fi | |||
|
|
|||
| local arcadeServicesSource="https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-tools/nuget/v3/index.json" | |||
| local arcadeServicesSource="https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-eng/nuget/v3/index.json" | |||
There was a problem hiding this comment.
Changes to eng/common must not be made in the VMR. You probably want to make this change in src/arcade/eng/common/darc-init.sh (which probably is already done). That's the location that flows to repos in and outside of the VMR.
There was a problem hiding this comment.
OK. I'll remove this. Yeah, the change is already in arcade.
There was a problem hiding this comment.
Fixed with 0734954
| @@ -311,6 +322,13 @@ jobs: | |||
| sbomEnabled: false | |||
|
|
|||
| steps: | |||
| - ${{ if not(parameters.isBuiltFromVmr) }}: | |||
| # Synchronize new content in the VMR during PRs (we expect this to come | |||
There was a problem hiding this comment.
This comment doesn't seem complete.
There was a problem hiding this comment.
Yeah, it was the original comment I brought back along with the surrounding code. I'll remove the content in parenthesis as it doesn't add any value.
Here's the same comment in P4 branch:
There was a problem hiding this comment.
Fixes with 9981a4f
|
PR checks are hitting known NuGet Audit errors - will likely need to wait until #546 is merged before rerunning checks. |
Contributes to: dotnet/arcade-services#4539
This PR is basically bringing back support for VMR builds that are launched from individual repos, and not from VMR. It essentially reverts the removal of
isBuiltFromVmrproperty and associated logic, that was done with: #226Additionally there are few tweaks:
vmr-pull-updates.yml. The template is referenced using@selfand resolved from repo sources.@self, in template references, as they were unnecessaryVmr syncing template and scripts will live in repo sources, under
eng/commonand will be provided to all repos viaarcadeupdates.Full verification build: https://dev.azure.com/dnceng/internal/_build/results?buildId=2708573&view=results There is a known failure in source-build poison tests, that exists in the baseline as well.