Follow-up and fixes from outer/inner removal #423
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow-up on #176 Also noticed that the YML was wrong. I tested the change in SBRP and the syntax now works. Rename PrebuiltUsage to TrackPrebuiltUsage property names and the file itself. Fix the NuGetPackageRoot cache defines in RepoLayout.props. They need to be in sync with the ones in tools.sh / tools.ps1. Source-only builds should use the repo local cache unless the NUGET_PACKAGES env var is explicitly set.
This was referenced May 7, 2025
jkoritzinsky
approved these changes
May 7, 2025
|
@ViktorHofer I'm still seeing the roslyn errors (dotnet/source-build#5135) when I build main (which includes #176). Should this PR fix that? |
No, this PR is unrelated to that. Let's move the discussion over to dotnet/source-build#5135 |
|
That one was incomplete. Submitted #433 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up on #176
Noticed that the YML was wrong. I tested the change in SBRP and the syntax now works.
Rename PrebuiltUsage to TrackPrebuiltUsage property names and the file itself.
Fix the NuGetPackageRoot cache defines in RepoLayout.props. They need to be in sync with the ones in tools.sh / tools.ps1. Source-only builds should use the repo local cache unless the NUGET_PACKAGES env var is explicitly set.