8000 Update link to NetTrace format by danroth27 · Pull Request #46069 · dotnet/docs · GitHub
[go: up one dir, main page]

Skip to content

Update link to NetTrace format #46069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

danroth27
Copy link
Member
@danroth27 danroth27 commented May 9, 2025

The EventPipe format was moved to a different file as part of microsoft/perfview#2170.


Internal previews

📄 File 🔗 Preview link
docs/core/diagnostics/eventpipe.md docs/core/diagnostics/eventpipe

The format was moved to a different file as part of microsoft/perfview#2170.
@danroth27 danroth27 requested review from tommcdon and a team as code owners May 9, 2025 20:54
@dotnetrepoman dotnetrepoman bot added this to the May 2025 milestone May 9, 2025
@danroth27 danroth27 requested a review from cincuranet May 9, 2025 20:54
@danroth27 danroth27 requested a review from noahfalk May 9, 2025 20:55
Copy link
Member
@noahfalk noahfalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @danroth27!

Copy link
Contributor
@gewarren gewarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since EventTrace hadn't been mentioned previously and the document title uses "NetTrace", doesn't it make more sense to use NetTrace instead of EventTrace?

@@ -19,7 +19,7 @@ EventPipe aggregates events emitted by runtime components - for example, the Jus

The events are then serialized in the `.nettrace` file format and can be written directly to a file or streamed through a [diagnostic port](./diagnostic-port.md) for out-of-process consumption.

To learn more about the EventPipe serialization format, refer to the [EventPipe format documentation](https://github.com/microsoft/perfview/blob/main/src/TraceEvent/EventPipe/EventPipeFormat.md).
To learn more about the EventTrace format, refer to the [EventTrace format documentation](https://github.com/microsoft/perfview/blob/main/src/TraceEvent/EventPipe/NetTraceFormat.md).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
To learn more about the EventTrace format, refer to the [EventTrace format documentation](https://github.com/microsoft/perfview/blob/main/src/TraceEvent/EventPipe/NetTraceFormat.md).
To learn more about the NetTrace format, see the [NetTrace format documentation](https://github.com/microsoft/perfview/blob/main/src/TraceEvent/EventPipe/NetTraceFormat.md).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh you are absolutely right, I looked too quickly :) NetTrace is the proper term.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0