8000 Add support for standalone publish pipeline by lbussell · Pull Request #1704 · dotnet/docker-tools · GitHub
[go: up one dir, main page]
Skip to content

Add support for standalone publish pipeline #1704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
May 28, 2025
Merged

Add support for standalone publish pipeline #1704

merged 16 commits into from
May 28, 2025

Conversation

lbussell
Copy link
Contributor
@lbussell lbussell commented May 8, 2025

Part 1/2 of: https://github.com/dotnet/dotnet-docker-internal/issues/7414

  • Make source build pipeline ID and pipeline run ID parameterized (this is the pipeline that we will be publishing images from)
  • Add parameter for standalone publishes that results in the publish stage having no dependencies on
    other stages
  • Added some extra command logging to some script steps
  • Tried to make publish job source code easier to read by adding whitespace.

@lbussell lbussell requested a review from a team as a code owner May 8, 2025 17:22
@lbussell lbussell mentioned this pull request May 8, 2025
Draft
@lbussell
Copy link
Contributor Author
lbussell commented May 8, 2025

The changes to print the ImageBuilder commands before running them ended up resolving some variables too early which failed in the public where those variables aren't defined. Since those changes are unrelated to the goal of this PR, I reverted the change.

mthalman
mthalman reviewed May 8, 2025
View reviewed changes
@lbussell lbussell marked this pull request as draft May 14, 2025 21:10
@lbussell lbussell force-pushed the release-promotion-changes branch from 89894e7 to bb78239 Compare May 14, 2025 21:12
@lbussell lbussell marked this pull request as ready for review May 15, 2025 21:14
@lbussell lbussell requested a review from mthalman May 16, 2025 17:35
mthalman
mthalman reviewed May 19, 2025
View reviewed changes
@lbussell lbussell force-pushed the release-promotion-changes branch from 7970bd4 to 8514173 Compare May 27, 2025 18:32
@lbussell lbussell force-pushed the release-promotion-changes branch from dca83f2 to a48beef Compare May 27, 2025 22:41
@lbussell lbussell marked this pull request as draft May 28, 2025 16:06
@lbussell
Copy link
Contributor Author

OK, finally got this working. Here is an example pipeline run of using the sourceBuildId parameter to test an ImageBuilder image that was built in a separate pipeline run: https://dev.azure.com/dnceng/internal/_build/results?buildId=2718653&view=results

@lbussell lbussell marked this pull request as ready for review May 28, 2025 18:31
@lbussell lbussell requested a review from mthalman May 28, 2025 19:10
@lbussell
Copy link
Contributor Author

/cc @dagood minor breaking change - the variable sourceBuildId is now a pipeline parameter called sourceBuildPipelineRunId.

@lbussell lbussell merged commit 29d405e into dotnet:main May 28, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mthalman mthalman mthalman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lbussell @mthalman
0