[go: up one dir, main page]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING CHANGE: drop log_code from manifest #9413

Merged
merged 1 commit into from
Nov 10, 2023
Merged

BREAKING CHANGE: drop log_code from manifest #9413

merged 1 commit into from
Nov 10, 2023

Conversation

yufeih
Copy link
Contributor
@yufeih yufeih commented Nov 10, 2023

The log_code was added to manifest to surface aggregated file level error codes in the OPS HTML build report. Drop this field from manifest.json since the OPS HTML build report removed this column and docfx been pivoted toward open source.

@yufeih yufeih added the breaking-change Makes the pull request appear in "Breaking Changes" section of the next release note label Nov 10, 2023
Copy link
codecov bot commented Nov 10, 2023

Codecov Report

Attention: 20 lines in your changes are missing coverage. Please review.

Files Coverage Δ
...Swagger/Internals/JsonLocation/JsonLocationInfo.cs 85.71% <100.00%> (ø)
...fx.Build/Conceptual/ConceptualDocumentProcessor.cs 89.28% <ø> (ø)
src/Docfx.Build/ManifestUtility.cs 65.51% <ø> (-5.92%) ⬇️
src/Docfx.Common/Path/PathUtility.cs 52.08% <ø> (+9.46%) ⬆️
src/Docfx.Plugins/ManifestItem.cs 100.00% <ø> (+14.28%) ⬆️
src/Docfx.Common/StringExtension.cs 58.82% <0.00%> (-2.29%) ⬇️
src/Docfx.Build/DocumentBuilder.cs 79.66% <70.76%> (-0.99%) ⬇️

... and 4 files with indirect coverage changes

📢 Thoughts on this report? Let us know!

@yufeih yufeih merged commit 16b4bc3 into main Nov 10, 2023
8 checks passed
@yufeih yufeih deleted the nologcode branch November 10, 2023 07:18
@yufeih yufeih changed the title chore: drop log_code from manifest BREAKING CHANGE: drop log_code from manifest Nov 13, 2023
p-kostov pushed a commit to ErpNetDocs/docfx that referenced this pull request Jun 28, 2024
Co-authored-by: Yufei Huang <yufeih@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change Makes the pull request appear in "Breaking Changes" section of the next release note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant