[DRAFT] Vmr verification in repo PRs #460
Conversation
Because I was testing the changes in this repo and created a pipeline in this repo. Perhaps I should have done it in If others also think that this should be done in |
|
And, the checks are failing as the target VMR sha does not contain the fixes from dotnet/dotnet#546 |
That work has to be done anyway. And all that we gain by getting this in here first is limited to just the deployment-tools repo. So it's not like a delay really costs us that much. |
You are going to have to checkin to arcade though right? If you check them in here, they will immediately get overridden by the next flow PR. I would use this as your validation arena and open a PR in arcade to checkin the eng/common changes. |
OK - I'll mark this PR as draft and have the arcade changes reviewed instead. |
|
I've triggered the Maestro subscription to get the latest VMR SHA in this repo, which would help with build errors in checks. |
|
/azp run deployment-tools-unified-build |
|
Azure Pipelines failed to run 1 pipeline(s). |
|
OK, unified-build pipeline was running originally, but since I got the latest backflow it complains that Will update the PR. |
dbc9c23 to
88dc55d
Compare
|
This was used for validation of changes in dotnet/arcade#15840. Everything looks good. Closing. |
Will create an arcade PR, for reviewing of these changes. This PR is for validation of the changes.
Contributes to: dotnet/arcade-services#4539
This PR brings necessary pipeline templates and associated scripts, for updating and building VMR as part of repo PR verification.
eng/commonwhich is owned byarcade. As soon as this PR is merged, I will make the same changes in thearcaderepo.vmr-syncscripts use theDarctool, which required a tools manifest file in.config. This will need to be added to any repo that would want to onboard this experience. I could not find a different way to enable this, and it just follows what we had insdkbefore.vmr-syncscripts is the same as in https://github.com/dotnet/sdk/pull/48351/files#diff-05db8cf030b53040062f45ed99f7c8b96efdc35c5e90bc52e03db5fd14c472e8NuGetforsdkrepo. That will be implemented in a follow up PR insdkrepo, so that it can be properly tested first. There is some new code, invmr-syncfor doing the additional syncs, but I believe it's untested or would require further tweaks.