This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Implement and expose Console.TreatControlCAsInput #6669
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This provides Windows and Unix implementations of TreatControlCAsInput, and exposes it in the contract. The Windows implementation is ported from the full framework. The Unix implementation relies on setting the terminal's IGNBRK flag, which tells it to allow breaks to be treated as input rather than generating signals. This mostly results in the same behaviors as on Windows. However, one notable difference is it doesn't just affect ctrl-C, but all of the ctrl-*s that result in signals, e.g. ctrl-\, ctrl-Z, etc.
|
Thanks, Pallavi. |
stephentoub
added a commit
that referenced
this pull request
Mar 7, 2016
Implement and expose Console.TreatControlCAsInput
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
Implement and expose Console.TreatControlCAsInput Commit migrated from dotnet/corefx@6d50e1e
Sign up for free
to subscribe to this conversation on GitHub.
5BDC
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides Windows and Unix implementations of TreatControlCAsInput, and exposes it in the contract. The Windows implementation is ported from the full framework. The Unix implementation relies on setting the terminal's ISIG flag, which controls whether it generates signals. This mostly results in the same behaviors as on Windows. However, one notable difference is it doesn't just affect ctrl-C, but all of the ctrl-*s that result in signals, e.g. ctrl-, ctrl-Z, etc.
cc: @pallavit, @andschwa
Closes https://github.com/dotnet/corefx/issues/4636