This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Update build instructions to include FreeBSD. #2043
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
cc: @JeremyKuhne |
| @@ -45,7 +45,7 @@ Coding Guidelines | |||
| Building from Source | |||
| ==================== | |||
|
|
|||
| - [Building on Linux](linux-instructions.md) | |||
| - [Building on Unixes](unix-instructions.md) | |||
There was a problem hiding this comment.
I'd change it to "Building CoreFX on FreeBSD, Linux and OSX" so it matches the title on the target page.
d673012 to
2636cfc
Compare
| @@ -76,3 +76,5 @@ System.Diagnostics.FileVersionInfo.Tests.csproj does not build on Unix. https:// | |||
| System.Diagnostics.Debug.Tests does not build on Unix. https://github.com/dotnet/corefx/issues/1609 | |||
|
|
|||
| Mono fails when trying to get custom attributes on CoreFx assemblies. https://bugzilla.xamarin.com/show_bug.cgi?id=29679 | |||
|
|
|||
| Some third party dependencies may or incorrectly assume that `bash` is always installed in `/bin/`. This can manifest itself in errors like `corefx/packages/dnx-mono.1.0.0-beta5-11760/bin/dnu: not found`. The simplest way to get around this until fixed upstream is simply making the assumption correct: `sudo ln -s /usr/local/bin/bash /bin/bash`. | |||
There was a problem hiding this comment.
The 'or' in this sentence should be removed.
|
One minor wording issue; otherwise, LGTM. |
| @@ -1,5 +1,5 @@ | |||
| Building CoreFX on Linux | |||
| ======================== | |||
| Building CoreFX on FreeBSD, Linux and OSX | |||
|
LGTM modulo outstanding comments. |
2636cfc to
3d3dd8b
Compare
|
Fixed all nits. Good for merging now? :) |
stephentoub
added a commit
that referenced
this pull request
Jun 18, 2015
Update build instructions to include FreeBSD.
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
…ructions Update build instructions to include FreeBSD. Commit migrated from dotnet/corefx@bf5b0ab
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These instructions presume that that #2030 is committed and merged.
They also correct the error where build on all Unixes is referred to as building on Linux.
CC: @janhenke