[Mvc] Avoid exception in route analyzer #63033
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a potential exception in the MVC route analyzer by handling cases where IMethodSymbol.OverriddenMethod is unexpectedly null despite IMethodSymbol.IsOverride being true. Instead of throwing an exception, the code now gracefully returns null and treats such methods as non-controller actions.
Key Changes
- Replace exception throwing with graceful null handling in
GetDeclaringTypemethod - Update return type annotation to reflect nullable return value
- Add null check for declaring type before accessing properties
captainsafia
approved these changes
Aug 1, 2025
There was a problem hiding this comment.
LGTM! I won't gate on lack of tests in this case since we're notoriously lacking on test coverage for MVC analyzers and this particular scenario will be hard to change. The delta is small and defensive enough that it's not too concerning.
Let's hope I don't eat my words! 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid exception in route analyzer
Avoid throwing if
IMethodSymbol.OverriddenMethodisnull.Description
Avoid throwing if
IMethodSymbol.OverriddenMethodisnullifIMethodSymbol.IsOverrideistrue.I would have written a test, but there's no repo in the issue and I have no idea what would make this eventuality occur.
Fixes #59736