[OpenApi] Use GetCustomAttributes<T> #62987
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use `GetCustomAttributes<T>()` instead of `GetCustomAttributes().OfType<ValidationAttribute>()` to avoid need to use LINQ.
There was a problem hiding this comment.
Pull Request Overview
This PR modernizes the use of reflection by replacing GetCustomAttributes().OfType<T>() with the more efficient GetCustomAttributes<T>() method. This change removes the need for LINQ's OfType<T>() method and provides better performance.
- Replaces
GetCustomAttributes().OfType<ValidationAttribute>()withGetCustomAttributes<ValidationAttribute>()
| } | ||
|
|
||
| if (parameterInfo.GetCustomAttributes().OfType<ValidationAttribute>() is { } validationAttributes) | ||
| if (parameterInfo.GetCustomAttributes<ValidationAttribute>() is { } validationAttributes) |
There was a problem hiding this comment.
Good optimization! Using GetCustomAttributes() is more efficient than GetCustomAttributes().OfType() as it avoids the overhead of boxing and LINQ enumeration.
Copilot uses AI. Check for mistakes.
captainsafia
approved these changes
Jul 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use GetCustomAttributes
Use
GetCustomAttributes<T>().Description
Use
GetCustomAttributes<T>()instead ofGetCustomAttributes().OfType<T>()to avoid need to use LINQ.