Add metrics to Identity #62078
Merged
Add metrics to Identity #62078
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 27, 2025
c68f365 to
53c0e78
Compare
|
Ready to review. Please take a look. |
|
@MackinnonBuck I've added metrics to some of the passkey methods you recently added. |
There was a problem hiding this comment.
Pull Request Overview
This PR instruments UserManager and SignInManager with OpenTelemetry-compatible metrics, extends test helpers to support metrics collection, and updates existing tests and project references to validate the new metrics.
- Introduces
UserManagerMetricsandSignInManagerMetricsand registers them via DI - Augments
MockHelpersandTestUserManager/TestSignInManagerto accept anIMeterFactoryand emit metrics - Updates tests across
Identity.Testto assert that the correct tags are recorded for each metric
Reviewed Changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/Identity/Extensions.Core/src/UserManagerMetrics.cs | New metrics class for user manager operations |
| src/Identity/Extensions.Core/src/UserManager.cs | Instruments all public methods to record metrics and exposes ServiceProvider |
| src/Identity/Core/src/SignInManagerMetrics.cs | New metrics class for sign-in manager operations |
| src/Identity/Core/src/SignInManager.cs | Instruments sign-in methods to record metrics |
| src/Identity/test/Shared/MockHelpers.cs | MockUserManager/TestUserManager updated to accept IMeterFactory |
| src/Identity/test/Shared/MetricsHelpers.cs | New helper for asserting metric tag collections |
| src/Identity/test/Identity.Test/UserManagerTest.cs | Tests updated to collect and assert on emitted metrics |
| src/Http/Authentication.Core/src/AuthenticationService.cs | Minor doc-comment fix in authentication service |
| src/Http/Authentication.Abstractions/src/IAuthenticationService.cs | Minor doc-comment fix in auth service interface |
Comments suppressed due to low confidence (3)
src/Identity/Extensions.Core/src/UserManager.cs:1255
- Method name 'ResolveFromtRolesCoreAsync' contains a typo and is inconsistent with the public API. Rename it to 'RemoveFromRolesCoreAsync' to match 'RemoveFromRolesAsync'.
throw;
src/Http/Authentication.Core/src/AuthenticationService.cs:148
- [nitpick] The doc comment has a redundant 'in'; consider revising to 'Sign in a principal for the specified authentication scheme.'
/// Sign in a principal in for the specified authentication scheme.
src/Http/Authentication.Abstractions/src/IAuthenticationService.cs:43
- [nitpick] The doc comment has a redundant 'in'; consider revising to 'Sign in a principal for the specified authentication scheme.'
/// Sign in a principal in for the specified authentication scheme.
a637d35 to
c3cb40e
Compare
|
API review feedback applied. Please do a final review and lets get this merged 🙏 |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
halter73
approved these changes
Jul 8, 2025
There was a problem hiding this comment.
Do you think it's worth it to file an issue for RoleManager metrics like @MackinnonBuck suggested?
249c738 to
562021c
Compare
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #52996