8000 Add WebAssemblyHotReloadCapabilities to Microsoft.AspNetCore.Components.WebAssembly.props by tmat · Pull Request #61946 · dotnet/aspnetcore · GitHub
[go: up one dir, main page]
Skip to content

Add WebAssemblyHotReloadCapabilities to Microsoft.AspNetCore.Components.WebAssembly.props #61946

8000 New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add WebAssemblyHotReloadCapabilities to Microsoft.AspNetCore.Components.WebAssembly.props #61946

wants to merge 1 commit into from
+1 −0

Conversation

tmat
Copy link
Member
@tmat tmat commented May 14, 2025

dotnet-watch expects capabilities to be specified by the project for projects targeting net10+

@tmat tmat requested review from wtgodbe and a team as code owners May 14, 2025 21:42
@github-actions github-actions bot added the area-blazor Includes: Blazor, Razor Components label May 14, 2025
wtgodbe
wtgodbe requested changes May 14, 2025
View reviewed changes
Copy link
Member
@wtgodbe wtgodbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please undo submodule changes

@lewing lewing requested a review from maraf May 14, 2025 22:26
@tmat tmat force-pushed the WasmHotReloadCaps branch from c04abaa to e812712 Compare May 14, 2025 22:30
javiercn
javiercn reviewed May 16, 2025
View reviewed changes
...onents/WebAssembly/WebAssembly/src/targets/Microsoft.AspNetCore.Components.WebAssembly.props
@@ -2,6 +2,7 @@
<PropertyGroup>
<BlazorWebAssemblyJSPath>$(MSBuildThisFileDirectory)blazor.webassembly.js</BlazorWebAssemblyJSPath>
<BlazorRoutingEnableRegexConstraint Condition="'$(BlazorRoutingEnableRegexConstraint)' == ''">false</BlazorRoutingEnableRegexConstraint>
<WebAssemblyHotReloadCapabilities>Baseline;AddMethodToExistingType;AddStaticFieldToExistingType;NewTypeDefinition;ChangeCustomAttributes;AddInstanceFieldToExistingType;GenericAddMethodToExistingType;GenericUpdateMethod;UpdateParameters;GenericAddFieldToExistingType</WebAssemblyHotReloadCapabilities>
Copy link
Member
@javiercn javiercn May 16, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this go into the \build\*.props file for the Hot Reload agent package long term?

/cc: @maraf

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so. This is specific to WASM. In other cases the agent retrieves the information from the runtime. The problem with WASM is that the runtime (and the agent) might not be loaded yet into the browser at the point we need the information.

@tmat
Copy link
Member Author
tmat commented May 17, 2025

Please undo submodule changes

@wtgodbe Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wtgodbe wtgodbe wtgodbe requested changes

@javiercn javiercn javiercn approved these changes

@maraf maraf Awaiting requested review from maraf

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
area-blazor Includes: Blazor, Razor Components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tmat @javiercn @wtgodbe
0