8000 Avoid the use of InitialTargets in arcade tests by ViktorHofer · Pull Request #15743 · dotnet/arcade · GitHub
[go: up one dir, main page]

Skip to content

Avoid the use of InitialTargets in arcade tests #15743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 15, 2025

Conversation

ViktorHofer
Copy link
Member
@ViktorHofer ViktorHofer commented Apr 15, 2025

Alternative to #15738. See that PR for the motivation.

Avoiding InitialTargets altogether here makes sense as it's more performant and there's no need to run the validation target as an initial target.

To double check:

Alternative to #15738. See that PR for the motivation.
Copy link
Member
@AR-May AR-May left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ViktorHofer ViktorHofer merged commit cd1ab27 into main Apr 15, 2025
11 checks passed
@ViktorHofer ViktorHofer deleted the InitialTargetsArcadeFix branch April 15, 2025 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0