Remove installing python in install-microbuild.yml #15734
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The build currently prints: > ##[warning]Specifying an exact version is not recommended on Microsoft-Hosted agents. Patch versions of Python can be replaced by new ones on Hosted agents without notice, which will cause builds to fail unexpectedly. It is recommended to specify only major or major and minor version (Example: `3` or `3.9`) This is wrong, we're not specifying an exact version, but the task just checks that there's a third component in the version string: https://github.com/microsoft/azure-pipelines-tasks/blob/f953dbc84a4564856207919220f2001535812d26/Tasks/UsePythonVersionV0/versionspec.ts#L24-L34 We can use just the major.minor to fix the warning.
There was a problem hiding this comment.
I think that we can remove the python installation entirely because the dependency is no longer needed when using the ESRP CLI tooling: https://dev.azure.com/dnceng/internal/_build/results?buildId=2686414&view=logs&j=4166124c-2a68-5c8d-2aa8-71d962d96b1e&t=7f73f132-529c-59c0-6d64-cc0d47c96472
|
@ellahathaway even better :) updated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No longer needed.