Speed up execution by offloading logging #75
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's reasonable. But for this usage (just using a BufferBlock as a hand-off mechanism), it'd be better to use the newer channels library.
|
jeffhandley
reviewed
Aug 2, 2021
Co-authored-by: Jeff Handley <jeffhandley@users.noreply.github.com>
Co-authored-by: Jeff Handley <jeffhandley@users.noreply.github.com>
|
CI is failing on what looks like a missing using statement to get |
|
OK, changed from DataFlow to Channels. Super easy! |
jeffhandley
approved these changes
Aug 3, 2021
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move console writes to a separate thread.
On that thread, batch the calls to console.
Don't continue batching if the color changes.
Don't continue batching if it's been over a second. [Note, this isn't perfect; if another message doesn't come in for a while, it will wait. But it will never fail to write.]
Add logging to a file, since a large run will exhaust the console buffer.
With these changes, a small run was sped up from about 10-11 sec to 7 sec. When running over the whole tree, it can save minutes.
@stephentoub this is my first time using DataFlow blocks. Does it seem reasonable?