Improve the performance of the RtxtParser. #9839
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
There are some small improvements in the RtxtParser that can be done to improve the performance of the parser. This commit includes the following changes: 1. Update the `enum` to be `byte`. This saves us a few bytes per instance. 2. Reorder the fields to reduce padding. 3. Encode is a type is a stylable into the `RType` enum. This allows us to reduce the number of `if` statements in the parser.
86d1c5b to
7972349
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jonathanpeppers
approved these changes
Mar 3, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some small improvements in the RtxtParser that can be done to improve the performance of the parser. This commit includes the following changes:
enumto bebyte. This saves us a few bytes per instance.RTypeenum.The following table shows the improvements for 10000 items. We have to use a large number to
see the improvements. Note that the default Maui template has about 7000 entries in the R.txt file.
So this is not an unreasonable test size.