8000 Cleanup: remove `src\Xamarin.Android.Build.Tasks\Xamarin.Android.PCLSupport.*` and other unshipped MSBuild files by Copilot · Pull Request #10344 · dotnet/android · GitHub
[go: up one dir, main page]

Skip to content

Conversation

Copilot
Copy link
Contributor
@Copilot Copilot AI commented Jul 25, 2025

Removes MSBuild targets/props files that are not shipped in installers and not used in .NET 6+ projects.

Files removed:

  • src/Xamarin.Android.Build.Tasks/Xamarin.Android.PCLSupport.targets
  • src/Xamarin.Android.Build.Tasks/Xamarin.Android.PCLSupport.props
  • src/Xamarin.Android.Build.Tasks/Xamarin.Android.FSharp.targets
  • src/Xamarin.Android.Build.Tasks/Xamarin.Android.VisualBasic.targets

Analysis:

  • PCLSupport files: Only ever used/imported in legacy Xamarin.Android projects and are not used in .NET 6+ projects
  • FSharp/VisualBasic targets: Existed in source but were never included in build-tools/installers/create-installers.targets, meaning they were never shipped to users
  • No F# or VB.NET projects exist in this repository that would reference these targets
  • Xamarin.Android.Build.Tasks.targets correctly remains as it's used for build-time purposes only

Verification:

  • ✅ Confirmed no references to removed files exist anywhere in the codebase
  • ✅ MSBuild processing continues to work normally after removal
  • ✅ Clean diff with no extra blank lines as requested

This cleanup removes 4 unused legacy files while ensuring no regressions to the build system.

Fixes #10343.


💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.

Co-authored-by: jonathanpeppers <840039+jonathanpeppers@users.noreply.github.com>
@Copilot Copilot AI changed the title [WIP] Cleanup: remove src\Xamarin.Android.Build.Tasks\Xamarin.Android.PCLSupport.* Cleanup: remove src\Xamarin.Android.Build.Tasks\Xamarin.Android.PCLSupport.* and other unshipped MSBuild files Jul 25, 2025
@Copilot Copilot AI requested a review from jonathanpeppers July 25, 2025 17:00
Copilot finished work on behalf of jonathanpeppers July 25, 2025 17:00
@jonathanpeppers jonathanpeppers marked this pull request as ready for review July 26, 2025 00:22
@jonathanpeppers jonathanpeppers enabled auto-merge (squash) July 26, 2025 00:24
@jonathanpeppers jonathanpeppers merged commit f20b382 into main Jul 26, 2025
59 checks passed
@jonathanpeppers jonathanpeppers deleted the copilot/fix-10343 branch July 26, 2025 00:50
@github-actions github-actions bot locked and limited conversation to collaborators Aug 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cleanup: remove src\Xamarin.Android.Build.Tasks\Xamarin.Android.PCLSupport.*

2 participants

0