Backport 6.0 | Nuget Audit Sources #3321
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d60c4cb to
e74434a
Compare
cheenamalhotra
approved these changes
May 2, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/6.0 #3321 +/- ##
===============================================
- Coverage 72.75% 72.60% -0.16%
===============================================
Files 285 285
Lines 59162 59165 +3
===============================================
- Hits 43045 42954 -91
- Misses 16117 16211 +94
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: This is a simple backport of the Nuget Audit settings from the main branch to the 6.0 branch. There is a slight change from the implementation in main, since technically the
<nugetaudit>tag does not support theconditionattribute. The solution is to move it to its own property group. This eliminates an IDE warning when editing the file in an IDE.Reminder that the reason for disabling auditing on official builds is that the official builds are only allowed to access central feed services (ie, ADO artifacts). The nuget audit by default uses nuget.org. Accessing nuget.org from an official build causes the S360 errors.
Testing: Everything still builds locally as expected. I will kick off an official build against this branch to ensure it does not raise a S360 error.
https://sqlclientdrivers.visualstudio.com/ADO.Net/_build/results?buildId=114573&view=results