8000 Improve <LangVersion> selection by paulmedynski · Pull Request #3240 · dotnet/SqlClient · GitHub
[go: up one dir, main page]
Skip to content

Improve <LangVersion> selection #3240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 6, 2025
Merged

Improve <LangVersion> selection #3240

merged 2 commits into from
May 6, 2025

Conversation

paulmedynski
Copy link
Contributor

Improved the C# language version selection:

  • For .NET, let the SDK choose the best language version.
  • For everything else (Framework, Standard), explicitly choose C# 13.

I used the #error version preprocessor directive to validate that the expected C# version was being used for the MDS projects and the test projects.

@paulmedynski
User Story 33639: Remove <LangVersion> from build config
e834324 
- Testing conditional <LangVersion> for .NET Framework only.
@paulmedynski
User Story 33639: Remove <LangVersion> from build config
38b2cb3 
- Now choosing the natrual C# language version for .NET versions.
- Explictily setting C# 13 for non-.NET targets (Framework, Standard, etc).
@codecov Codecov
Copy link
codecov bot commented Mar 25, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.73%. Comparing base (1247ca4) to head (38b2cb3).
Report is 49 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3240      +/-   ##
==========================================
+ Coverage   72.69%   74.73%   +2.04%     
==========================================
  Files         303      314      +11     
  Lines       59718    75258   +15540     
==========================================
+ Hits        43414    56247   +12833     
- Misses      16304    19011    +2707
Flag Coverage Δ
addons 92.58% <ø> (ø)
netcore 76.52% <ø> (+1.41%) ⬆️
netfx 73.19% <ø> (+1.81%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@paulmedynski paulmedynski requested a review from Copilot March 25, 2025 11:53
Copilot
Copilot AI reviewed Mar 25, 2025
View reviewed changes
Copy link
@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (1)
  • src/Directory.Build.props: Language not supported

@paulmedynski paulmedynski added this to the 7.0-preview1 milestone Apr 2, 2025
@mdaigle mdaigle self-assigned this Apr 2, 2025
@edwardneal edwardneal mentioned this pull request Apr 5, 2025
Merged
@paulmedynski paulmedynski marked this pull request as ready for review April 29, 2025 13:10
@paulmedynski
Copy link
Contributor Author

/azp run

@azure-pipelines Azure Pipelines
Copy link
Azure Pipelines successfully started running 1 pipeline(s).

@paulmedynski
Copy link
Contributor Author

We can take this approach as implemented, or we can set to latest for all targets. I think I prefer the implemented approach for now. The latest approach would require us to ensure we lock down our SDKs on all build agents/images/pipelines. It may be the better long-term approach though.

@cheenamalhotra cheenamalhotra marked this pull request as draft May 2, 2025 22:28
@paulmedynski paulmedynski marked this pull request as ready for review May 6, 2025 11:01
@paulmedynski paulmedynski merged commit 2772a8c into main May 6, 2025
252 checks passed
@paulmedynski paulmedynski deleted the dev/paul/lang-version branch May 6, 2025 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@benrr101 benrr101 benrr101 approved these changes

@cheenamalhotra cheenamalhotra cheenamalhotra approved these changes

@samsharma2700 samsharma2700 samsharma2700 approved these changes

Assignees

@mdaigle mdaigle

Labels
None yet
Projects
None yet
Milestone
6.1-preview2
Development

Successfully merging this pull request may close these issues.
5 participants
@paulmedynski @benrr101 @cheenamalhotra @samsharma2700 @mdaigle
0