E531 [Bug Fix] Custom SimpleJob Id ignored by MattFromRVA · Pull Request #2491 · dotnet/BenchmarkDotNet · GitHub
[go: up one dir, main page]
Skip to content

[Bug Fix] Custom SimpleJob Id ignored#2491

Merged
AndreyAkinshin merged 3 commits intodotnet:masterfrom
MattFromRVA:feature/SimpleJob_bug_fix
Jan 5, 2024
Merged

[Bug Fix] Custom SimpleJob Id ignored#2491
AndreyAkinshin merged 3 commits intodotnet:masterfrom
MattFromRVA:feature/SimpleJob_bug_fix

Conversation

@MattFromRVA
Copy link
Contributor
@MattFromRVA MattFromRVA commented Jan 2, 2024

Fixes #2473

@MattFromRVA
Copy link
Contributor Author
MattFromRVA commented Jan 2, 2024

@dotnet-policy-service agree

@MattFromRVA MattFromRVA marked this pull request as draft January 2, 2024 17:06
@MattFromRVA MattFromRVA marked this pull request as ready for review January 3, 2024 19:16
@AndreyAkinshin AndreyAkinshin merged commit 2990951 into dotnet:master Jan 5, 2024
@AndreyAkinshin AndreyAkinshin added this to the v0.13.12 milestone Jan 5, 2024
@AndreyAkinshin
Copy link
Member
AndreyAkinshin commented Jan 5, 2024

@MattFromRVA thanks for the PR! Indeed, it's an unpleasant bug and it's nice to have it fixed.

P.S. A side note: the whole Characteristic* infrastructure is a huge technical debt introduced in 2016. Back in those times, I had no idea about the actual feature set we needed, so I tried to design a flexible and generic approach. Unfortunately, the API turned out to be over-complicated, which is quite challenging to maintain. In my backlog, I have a long-living task of burning Characteristic* and redesigning the Job API from scratch targeting the current set of features. However, this task is not product-critical (the current system just works most of the time), so it's always deprioritized (no ETA for now).

@MattFromRVA
Copy link
Contributor Author
MattFromRVA commented Jan 5, 2024 •
edited
Loading

@AndreyAkinshin no problem! Thanks for the additional history. When that backlog item becomes a priority I would be happy to help contribute.

This was referenced Aug 1, 2025
Merged
Open
Closed
This was referenced Aug 17, 2025
Closed
Closed
Closed
This was referenced Sep 3, 2025
Closed
Closed
This was referenced Sep 11, 2025
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Sep 19, 2025
Closed
Closed
Closed
This was referenced Nov 1, 2025
Open
Closed
Closed
Closed
Closed
Closed
This was referenced Nov 9, 2025
Closed
Closed
Closed
This was referenced Nov 17, 2025
Closed
Closed
Closed
This was referenced Nov 30, 2025
Merged
Open
Open
Closed
This was referenced Dec 10, 2025
Open
Closed
This was referenced Dec 18, 2025
Closed
Closed
Closed
This was referenced Jan 1, 2026
Closed
Open
@dependabot dependabot bot mentioned this pull request Jan 8, 2026
Closed
This was referenced Jan 15, 2026
Open
Open
@dependabot dependabot bot mentioned this pull request Feb 5, 2026
Open
This was referenced Mar 6, 2026
Closed
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AndreyAkinshin AndreyAkinshin AndreyAkinshin approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v0.13.12

Development

Successfully merging this pull request may close these issues.

Custom SimpleJob Id ignored when the MinIterationTime attribute is used.

2 participants

@MattFromRVA @AndreyAkinshin
0