8000 + InProcessNoEmitToolchain (obsoletes the InProcessToolchain) by ig-sinicyn · Pull Request #1123 · dotnet/BenchmarkDotNet · GitHub
[go: up one dir, main page]

Skip to content

+ InProcessNoEmitToolchain (obsoletes the InProcessToolchain) #1123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 17, 2019

Conversation

ig-sinicyn
Copy link
Contributor
@ig-sinicyn ig-sinicyn commented Mar 30, 2019

As suggested here.

I've added a copy of InProcessToolchain, InProcessNoEmitToolchain, that has no emit-related code.
Origin classes marked obsolete, tests and usages updated.

Any suggestions are welcome, I'm not going to insist on this implementation.

Copy link
Member
@adamsitnik adamsitnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ig-sinicyn thank you!

@adamsitnik adamsitnik merged commit 12fdbe2 into dotnet:master Apr 17, 2019
@adamsitnik adamsitnik added this to the v0.11.6 milestone Apr 17, 2019
@ig-sinicyn
Copy link
Contributor Author

Always welcome:)
Please let me know if there will be issues with in-process toolchains.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0