Workaround for float reflows limit#3714
Merged
bsweeney merged 2 commits intodompdf:masterfrom Feb 12, 2026
Merged
Conversation
This counter was previously a static local variable, which made it impossible to reset. It could be problematic when generating multiple documents. This commit is a temporary workaround with minimal side-effects for this specific use case, before a proper fix can be implemented.
bsweeney
approved these changes
Feb 12, 2026
Member
|
nicely refactored, I appreciate that you made the property public static so users could modify during use and not have to modify the source |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #3713, related to #620.
Before someone can come up with a real fix (or a proof that this loop-prevention is not needed anymore), this PR resets the static reflows counter on every render.
By the way, users experiencing problems when rendering very large documents can override this limit externally to any absurd value that may suit their needs, for example: