10000 Implement `REVOKE ALL PRIVILEGES, GRANT OPTION ...` by jycor · Pull Request #2988 · dolthub/go-mysql-server · GitHub
[go: up one dir, main page]
Skip to content

Implement REVOKE ALL PRIVILEGES, GRANT OPTION ... #2988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 23, 2025
Merged

Implement REVOKE ALL PRIVILEGES, GRANT OPTION ... #2988

merged 6 commits into from
May 23, 2025

Conversation

jycor
Copy link
Contributor
@jycor jycor commented May 21, 2025 •
edited
Loading

This PR adds tests for REVOKE [IF EXISTS] ALL [PRIVILEGES], GRANT OPTION ... and implements the IGNORE UNKNOWN USER option.
There are changes to REVOKE PROXY, but it seems like that is unsupported so there are no tests.

Companion pr: dolthub/vitess#415

fulghum
fulghum approved these changes May 22, 2025
View reviewed changes
Copy link
Contributor
@fulghum fulghum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jycor jycor mentioned this pull request May 23, 2025
Closed
@jycor jycor merged commit 8c883e3 into main May 23, 2025
8 checks passed
@jycor jycor deleted the james/revoke branch May 23, 2025 18:14
@BrewTestBot BrewTestBot mentioned this pull request May 28, 2025
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fulghum fulghum fulghum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jycor @fulghum
0