10000 Add failing test for .jsx dependency by stevoland · Pull Request #402 · documentationjs/documentation · GitHub
[go: up one dir, main page]
Skip to content

Add failing test for .jsx dependency #402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 3, 2016
Merged

Add failing test for .jsx dependency #402

merged 1 commit into from
Jun 3, 2016

Conversation

stevoland
Copy link
Contributor

Error: Cannot find module './extension-required' from '/Users/stephencollings/workspace/documentation/test/fixture'

According to #369 this should work but doesn't seem to. Any pointers anyone?

Thanks

@tmcw
Copy link
Member
tmcw commented Apr 4, 2016

We'll need to pass extensions to module-deps for this to work.

@stevoland
Copy link
Contributor Author

@tmcw Ahh I see. It looks like passing a custom resolve function to module-deps is the only way?

tmcw added a commit that referenced this pull request Jun 3, 2016
@tmcw
Fix ability to require() JSON and other files without extension.
caa1637 
Fixes #402
@tmcw tmcw merged commit 93739c1 into documentationjs:master Jun 3, 2016
@tmcw
Copy link
Member
tmcw commented Jun 3, 2016

Thanks @stevoland ! Turned out module-deps has an extensions option we can use, and I merged in a fix that uses it and includes this testcase as part of #445

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stevoland @tmcw
0