Fix compat with Symfony 5 after a recent deprecation #1047
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
947bbe4 to
0538e66
Compare
nicolas-grekas
commented
Nov 6, 2019
| @@ -36,7 +36,7 @@ public function __construct(ManagerRegistry $registry) | |||
| /** | |||
| * {@inheritdoc} | |||
| */ | |||
| public function collect(Request $request, Response $response, Exception $exception = null) | |||
| public function collect(Request $request, Response $response, Throwable $exception = null) | |||
There was a problem hiding this comment.
this is the change that triggered all the rest
alcaeus
reviewed
Nov 6, 2019
| @@ -5,6 +5,7 @@ | |||
| "keywords": ["DBAL", "ORM", "Database", "Persistence"], | |||
| "homepage": "http://www.doctrine-project.org", | |||
| "license": "MIT", | |||
| "minimum-stability": "dev", | |||
There was a problem hiding this comment.
I suppose this is ok to avoid a bunch of composer config calls in .travis.yml - let's see if we have any adverse side effects.
alcaeus
approved these changes
Nov 8, 2019
|
Thanks @nicolas-grekas! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This drops support for Symfony 3.4, but the alternative is ugly, so I think we should do it, for v2 of course.
Follows symfony/symfony#34230 and symfony/symfony#34230