8000 feature: support customized sidebar item name from content by Jacco-V · Pull Request #1825 · docsifyjs/docsify · GitHub
[go: up one dir, main page]
Skip to content

feature: support customized sidebar item name from content #1825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 17 commits into
base: develop
Choose a base branch
from
Open

feature: support customized sidebar item name from content #1825

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
eb5f939
Implement support for setting a customized sidebar item name from the…
Jun 22, 2022
a764b02
Push both title and label to toc (=table of contents) array
Jun 23, 2022
cfca427
Apply changes to duplicate code block
Jun 23, 2022
cdca395
Apply new functionality to doc file
Jun 23, 2022
f536e72
Refactor for better readability
Jun 23, 2022
e581df7
Support quoted strings for config value arguments
Jun 23, 2022
27513e0
Update render-util tests
Jun 23, 2022
cf9e00b
replace function chaining with more modified regex
Jun 23, 2022
83e5795
replace 'label' with 'text' for more intuitive variable naming
Jul 4, 2022
b838fc3
Fix incorrect (escaped) quoted string parsing
Jul 4, 2022
da7937e
Fix logic for html-escaped str argument
Jul 4, 2022
d66d22d
Fix test arguments to match reality
Jul 4, 2022
71288be
Change test to provide html-escaped string
Jul 4, 2022
79e738a
Change regex to work directly on html-escaped string
Jul 4, 2022
a6333ec
Add support for marked.md `smartypants` 'smart' quotes
Jul 4, 2022
5a1e655
Merge branch 'develop' into feature-customizableSidebarItemName
Koooooo-7 Aug 30, 2022
03fda8b
Merge branch 'develop' into feature-customizableSidebarItemName
jhildenbiddle Sep 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix logic for html-escaped str argument 
Because the provided `str` argument has been html-escaped, with backslashes stripped, we can unfortunately not support escaped characters in quoted strings.
  • Loading branch information
Jacco-V committed Jul 4, 2022
commit da7937e340ec44b514fc397b3c1b1734eb938952
9 changes: 5 additions & 4 deletions src/core/render/utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,19 +23,20 @@ export function getAndRemoveConfig(str = '') {

if (str) {
str = str
.replace(/"/g, '"')
.replace(
/(?:^|\s):([\w-]+:?)=?([\w-%]+|"(?:[^"\\]|\\.)*")?/g,
/(?:^|\s):([\w-]+:?)=?([\w-%]+|"[^"]*")?/g, // Note: because the provided `str` argument has been html-escaped, with backslashes stripped, we cannot support escaped characters in quoted strings :-(
(m, key, value) => {
if (key.indexOf(':') === -1) {
config[key] = (value && value.replace(/"/g, '')) || true;
config[key] = (value && value.replace(/"/g, '')) || true;
return '';
}

return m;
}
)
.replace(/^('|")/, '')
.replace(/('|")$/, '')
.replace(/^('|")|('|")$/g, '')
.replace(/"/g, '"')
.trim();
}

Expand Down
0