Export symbols on windows. #60
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@GamePad64 please let me (and @jaredgrubb) know if you have any thoughts about this PR. |
|
Looks good to me |
Thank you for taking a look. |
|
@jaredgrubb when you have a chance, I would greatly appreciate it if you could look at this PR. The original author of the CMake changes is okay with the changes. I will gladly address any issues that result from this change in the future. Once this PR is merged, I can start using docopt in my own project :). This library will allow my project to have a very useful command line interface. |
|
Looks good to me! |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue raised by @klshrinidhi in #57. Basically, MSVC should have produced a
docopt.libfile but it did not because no symbols were exported. See here.So, this PR causes two functions to be exported (available for use by users of
docopt.dll) using a set of macros that are commonly used to handle this scenario; see here and here.As a result, a
docopt.libfile is now produced, thus allowing Windows/MSVC users to make use of thedocopt.dllshared library.