This repository was archived by the owner on Feb 1, 2021. It is now read-only.
api: add undocumented /grpc endpoint available since API 1.40 #2944
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tibor Vass <tibor@docker.com>
|
Ping @tonistiigi @dperny @dhiltgen |
dhiltgen
approved these changes
May 8, 2019
|
|
||
| // postGRPC randomly chooses a node on the cluster and hijacks that connection. | ||
| func postGRPC(c *context, w http.ResponseWriter, r *http.Request) { | ||
| engine, err := c.cluster.RANDOMENGINE() |
There was a problem hiding this comment.
Not ideal, but seems acceptable for the time being.
|
@dperny is the CI failure unrelated? |
|
ci failure is almost certainly unrelated, but i don't know anything about the ci system here. |
|
looks fine. |
|
Upstream changes in the engine; moby/moby#38990 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Tibor Vass tibor@docker.com
This allows to use buildx with docker driver on swarm.