8000 distro: add rhel 8 and 9 by crazy-max · Pull Request #226 · docker/packaging · GitHub
[go: up one dir, main page]
Skip to content

distro: add rhel 8 and 9 #226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 4, 2025
Merged

distro: add rhel 8 and 9 #226

merged 1 commit into from
Jul 4, 2025

Conversation

crazy-max
Copy link
Member
@crazy-max crazy-max commented Jun 23, 2025 •
edited
Loading

@crazy-max crazy-max force-pushed the rhel branch 2 times, most recently from a6ae676 to 9c5e67b Compare June 23, 2025 13:31
@crazy-max
Copy link
Member Author
crazy-max commented Jun 23, 2025 •
edited
Loading

https://github.com/docker/packaging/actions/runs/15825678883/job/44605135410?pr=226#step:7:1101

0.080 + setarch x86_64 dnf builddep --nobest -y /root/rpmbuild/SPECS/docker-ce-cli.spec
0.499 Updating Subscription Management repositories.
0.499 Unable to read consumer identity
0.503 
0.503 This system is not registered with an entitlement server. You can use subscription-manager to register.
0.503 
0.574 Last metadata expiration check: 0:00:13 ago on Mon Jun 23 13:32:26 2025.
0.820 No matching package to install: 'libtool-ltdl-devel'
0.821 Not all dependencies satisfied
0.839 Error: Some packages could not be found.

Looks like there is no libtool-ltdl-devel package. I guess we need a valid RHEL subscription so it subscribes to codeready-builder-for-rhel-x-x86_64-rpms repo?

@neersighted It can be tested with:

RH_USER=foo RH_PASS=bar LOCAL_PLATFORM=1 docker buildx bake pkg-docker-engine-rhel8

@crazy-max crazy-max requested review from thaJeztah and vvoland June 23, 2025 13:50
@crazy-max crazy-max marked this pull request as ready for review June 23, 2025 13:50
@crazy-max crazy-max requested a review from neersighted June 23, 2025 14:00
crazy-max
crazy-max commented Jun 23, 2025
View reviewed changes
.github/workflows/.build.yml
Comment on lines +129 to +130
RH_USER: ${{ secrets.RH_USER }}
RH_PASS: ${{ secrets.RH_PASS }}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to set these secrets in repo settings

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can add those. We're still missing a license for ARM64 though, so only the AMD64 build will work for now.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we skip these in the public repo? (Mostly wondering if they could leak, as they're made accessible to the build / container).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're still missing a license for ARM64 though, so only the AMD64 build will work for now.

Oh there is specific license for arm64? Ok then maybe name the secret differently like RH_USER_X86 / RH_PASS_X86?

Should we skip these in the public repo? (Mostly wondering if they could leak, as they're made accessible to the build / container).

I think we need the subscription for building related to #226 (comment)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, the separate license is still on the same account so no need for separate secrets.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need the subscription for building related to #226 (comment)

Yeah, correct; it's not possible to build RHEL without the subscription; mostly considering that on docker-ce-packaging we skip building RHEL in the public repo (and only build in our private pipeline).

@crazy-max crazy-max force-pushed the rhel branch 2 times, most recently from 3c69690 to 5d49735 Compare June 27, 2025 10:24
@crazy-max
Copy link
Member Author

Pushed extra commit so it can build without an RHEL subscription

@crazy-max crazy-max force-pushed the rhel branch 4 times, most recently from afbc2d0 to 518c12e Compare June 29, 2025 14:15
vvoland
vvoland reviewed Jul 4, 2025
View reviewed changes
8000 pkg/credential-helpers/rpm/docker-credential-pass.spec Outdated
BuildRequires: gcc
%if ! 0%{?rhel} || (0%{?rhel} && 0%{?_rhn_enabled})
# libtool-ltdl-devel only available through a Red Hat subscription
BuildRequires: libtool-ltdl-devel
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, looks like we might even not need this package anymore.

It was needed by the pkcs11 library, but looks like it's no longer needed after docker/cli@cb3e55b

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah that's better then

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a test build and looks like it succeeds.

Also opened a PR to the current docker-ce-packaging to remove the ltdl deps: docker/docker-ce-packaging#1223

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Opened follow-up #232

@crazy-max crazy-max mentioned this pull request Jul 4, 2025
Merged
@crazy-max
distro: add rhel 8 and 9
9e72a90 
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
@crazy-max crazy-max merged commit b75ba92 into docker:main Jul 4, 2025
439 of 440 checks passed
@crazy-max crazy-max deleted the rhel branch July 4, 2025 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vvoland vvoland vvoland approved these changes

@thaJeztah thaJeztah Awaiting requested review from thaJeztah

@neersighted neersighted Awaiting requested review from neersighted

Assignees
No one assigned
Labels
area/ci area/distro/rhel area/pkg/buildx area/pkg/compose area/pkg/containerd area/pkg/credential-helpers area/pkg/docker-cli area/pkg/docker-engine
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@crazy-max @thaJeztah @vvoland
0