E546 Enable Ruff I (import sort), autofix by akx · Pull Request #3212 · docker/docker-py · GitHub
[go: up one dir, main page]

Skip to content

Conversation

akx
Copy link
Contributor
@akx akx commented Jan 3, 2024

I didn't have a good time sorting imports by hand in the tests for #3205, so maybe a machine should do it for us 🤖.

The first commit is entirely mechanical, but it turns out it uncovered circular import issues, so the second commit takes care of them.

Signed-off-by: Aarni Koskela <akx@iki.fi>
Signed-off-by: Aarni Koskela <akx@iki.fi>
@akx akx marked this pull request as ready for review January 3, 2024 19:51
@akx
Copy link
Contributor Author
akx commented Feb 8, 2024

Ping @milas? :)

@milas milas self-requested a review March 29, 2024 17:14
@milas milas self-assigned this Mar 29, 2024
@milas milas added the kind/chore Refactor, linter, CI, etc label Mar 29, 2024
Copy link
Contributor
@milas milas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (merging to main manually to handle merge conflict because setup.py is gone now)

milas added a commit that referenced this pull request Mar 29, 2024
@milas milas merged commit 336e65f into docker:main Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/chore Refactor, linter, CI, etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0